CI Fixups #994
Open
CI Fixups #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a change in the latest version of conda that requires explicit acceptance of terms of service to prevent CI pipeline failures. The changes ensure conda operates in a non-interactive mode suitable for CI environments.
- Adds
CONDA_NO_PROGRESS_BARS=1environment variable across CI workflows and build configurations - Explicitly accepts conda terms of service for required channels in Docker setup
- Enables debug output (
set -x) in Docker build for better troubleshooting
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Makefile | Sets and exports CONDA_NO_PROGRESS_BARS environment variable |
| .github/workflows/macos.yml | Adds CONDA_NO_PROGRESS_BARS=1 to macOS CI environment |
| .github/workflows/linux.yml | Adds CONDA_NO_PROGRESS_BARS=1 to Linux CI environment |
| .devcontainer/Dockerfile | Adds debug output, progress bar suppression, and explicit ToS acceptance for conda channels |
bpkroth
commented
Sep 23, 2025
bpkroth
commented
Sep 23, 2025
bpkroth
commented
Sep 23, 2025
| """ | ||
| target_kwargs = {} | ||
| for kword in target.__kwdefaults__: # or {} # intentionally omitted for now | ||
| for kword in target.__kwdefaults__ or {}: |
There was a problem hiding this comment.
Type check fixup. I don't remember what the comment was about ...
bpkroth
commented
Sep 23, 2025
.github/workflows/devcontainer.yml
Outdated
| - name: Run pytest with debug logging enabled for nightly runs | ||
| if: github.event_name == 'schedule' | ||
| #if: github.event_name == 'schedule' |
There was a problem hiding this comment.
Enable debug logging during all runs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
CI Fixups
Description
Pull prebuilt
pyrfrfrom conda to workaround devcontainer build error with pyrfr #1001Continue using debian
bookwormbase untilazure-cliadds support fortrixiedevcontainer missing azure-cli error #1002.See Also:
Type of Change
Testing
CI Pipeline runs again.